test: #18 RaygunErrorBoundary tests #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
commented
Oct 4, 2024
miquelbeltran
commented
Oct 4, 2024
| @@ -10,7 +10,7 @@ namespace Raygun.Blazor.Models | |||
| /// This exists because we need to parse some stuff from the browser to construct a proper <see cref="EnvironmentDetails" /> | |||
| /// instance. Also the <see cref="EnvironmentDetails" /> is a hot mess of JavaScript serialization inconsistency. | |||
| /// </remarks> | |||
| internal record BrowserSpecs | |||
| public record BrowserSpecs | |||
There was a problem hiding this comment.
Made public so it is accessible from the Raygun.Tests.Blazor.Server project
There was a problem hiding this comment.
I understand the need to do that, but it kind of breaks encapsulation a bit for the same of the code being ore testable. I think that's a choice that can be made consciously, but are there other ways to do this?
There was a problem hiding this comment.
Fixed it, see 45d0423 (#53)
miquelbeltran
commented
Oct 4, 2024
miquelbeltran
commented
Oct 4, 2024
miquelbeltran
commented
Oct 7, 2024
miquelbeltran
requested review from
a team,
nikz,
TheRealAgentK,
PanosNB and
sumitramanga
and removed request for
a team
miquelbeltran
commented
Oct 8, 2024
miquelbeltran
commented
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: #18
RaygunErrorBoundarytestsDescription 📝
RaygunErrorBoundaryRaygunErrorBoundarytests #18Type of change
Updates
Raygun.Tests.Blazor.Server.Raygun.Tests.Blazor.WebAssembly(project was empty, could be added again if necessary)TestComponentthat throws an exception when a button is clicked. This component is wrapped by theRaygunErrorBoundary.TestComponent, which throws an exception and gets captured, the tests verify that the http mock client has captured the exception. Testing the solution end-to-end.Test plan 🧪
Author to check 👓
Reviewer to check ✔️